Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogService #28

Closed
tischi opened this issue Dec 8, 2019 · 2 comments
Closed

LogService #28

tischi opened this issue Dec 8, 2019 · 2 comments
Assignees

Comments

@tischi
Copy link
Contributor

tischi commented Dec 8, 2019

@wolny
I am leaning towards going back to simply using the LogService to reduce the complexity of the code. In the end this is meant for usage in ImageJ anyway and it is actually quite easy to get a LogService:

final ImageJ ij = new ImageJ();
final LogService logService =  ij.log();

This is arguably easier than finding our LogServiceWrapper class.

@tischi
Copy link
Contributor Author

tischi commented Dec 8, 2019

...would it be OK for you if I did that?

@wolny
Copy link
Contributor

wolny commented Dec 12, 2019

Hey @tischi, I totally agree. It will be less clutter in the code and since you use it in from the ImageJ anyway there we shouldn't sweat too much to make the API generic

@wolny wolny closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants