This repository has been archived by the owner on Mar 9, 2018. It is now read-only.
Update add_gcm.rb with a comment in case of an upgrade #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a small explanation: the migration might fail if the index_rapns_notifications_multi doesn't exists and it's actually called index_rapns_notifications_on_delivered_failed_deliver_after
|
My patch at #181 includes a more complete fix for this issue (rather than just an explanatory comment, we should handle the situation automatically.) |
|
@jcoleman great, way better than what I did. |
|
Awesome. TBH I encountered the same problem and didn't think to look at the current open issues. I'd made the changes and pushed before I even realized that you'd already opened a similar issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small explanation: the migration might fail if the index_rapns_notifications_multi doesn't exists and it's actually called index_rapns_notifications_on_delivered_failed_deliver_after.
This depends on the base version of rapns from where you're upgrading from. I for example upgraded from version 2.0.5, revision 0f4b90d and it seems the index was renamed later.