Update add_gcm.rb with a comment in case of an upgrade #175

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@nicops

Just a small explanation: the migration might fail if the index_rapns_notifications_multi doesn't exists and it's actually called index_rapns_notifications_on_delivered_failed_deliver_after.

This depends on the base version of rapns from where you're upgrading from. I for example upgraded from version 2.0.5, revision 0f4b90d and it seems the index was renamed later.

@nicops nicops Update add_gcm.rb with a comment in case of an upgrade
Just a small explanation: the migration might fail if the index_rapns_notifications_multi doesn't exists and it's actually called index_rapns_notifications_on_delivered_failed_deliver_after
1bced2a
@jcoleman

My patch at #181 includes a more complete fix for this issue (rather than just an explanatory comment, we should handle the situation automatically.)

@nicops

@jcoleman great, way better than what I did.

@nicops nicops closed this Nov 21, 2013
@jcoleman

Awesome. TBH I encountered the same problem and didn't think to look at the current open issues. I'd made the changes and pushed before I even realized that you'd already opened a similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment