This repository has been archived by the owner on Mar 9, 2018. It is now read-only.
Reset sound default to "default" #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,7 @@ def self.up | |||
| change_column_null :rapns_apps, :certificate, true | |||
|
|
|||
| change_column :rapns_notifications, :error_description, :text | |||
| change_column :rapns_notifications, :sound, :string, :default => 'default' | |||
|
Added down migration and validation in separate class in master branch, see pull request 85: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The current apple docs suggest using the value of "default" to play a default sound. I can't see "1.aiff" anywhere. It is still optional, but having a default value shows people how to use the default sound and its not hard to use nil explicitly if the user wants to (as I already do).
I also added a test in here to validate that one of alert, badge or sound is present as is specified in the apple docs:
https://developer.apple.com/library/ios/#documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/ApplePushService/ApplePushService.html