Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP


Order of parameters to ExcelSheet::setNamedRange method was incorrect. #43

merged 1 commit into from

2 participants


This patch corrects the order of the setNamedRange method parameters to match the order of the underlying libxl function.

@iliaal iliaal merged commit 5732b29 into iliaal:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 20, 2013
  1. @jacksonja
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 excel.c
6 excel.c
@@ -3372,11 +3372,11 @@ EXCEL_METHOD(Sheet, setNamedRange)
SheetHandle sheet;
zval *object = getThis();
- long row, col, to_row, to_col;
+ long row, to_row, col, to_col;
char *name;
int name_len;
- if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sllll", &name, &name_len, &row, &col, &to_row, &to_col) == FAILURE) {
+ if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "sllll", &name, &name_len, &row, &to_row, &col, &to_col) == FAILURE) {
@@ -3394,7 +3394,7 @@ EXCEL_METHOD(Sheet, setNamedRange)
SHEET_FROM_OBJECT(sheet, object);
- RETURN_BOOL(xlSheetSetNamedRange(sheet, name, row, col, to_row, to_col));
+ RETURN_BOOL(xlSheetSetNamedRange(sheet, name, row, to_row, col, to_col));
/* }}} */
Something went wrong with that request. Please try again.