Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching for mod downloads #44

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SamuelMereau
Copy link
Collaborator

@SamuelMereau SamuelMereau commented Jun 24, 2023

This will group mods in batches of 5 and attempt to download all of them. If the mod is downloaded, it will remove it from the batch and add another mod which will then begin downloading.

@SamuelMereau SamuelMereau marked this pull request as draft June 24, 2023 07:51
@SamuelMereau SamuelMereau marked this pull request as ready for review June 24, 2023 08:06
@iliadsh
Copy link
Owner

iliadsh commented Jun 25, 2023

Very neat, though I tried this change and it seems like the mods are only downloaded one at a time, so the other bars just idle. Did it work with your Steam?

Also just personal preference, but I feel like 5 is too many at least for the current UI :p

@SamuelMereau SamuelMereau marked this pull request as draft June 25, 2023 09:31
Since Steam can only download one item at a time, if a download is taking too long we can start downloading the next item in the batch instead
@SamuelMereau SamuelMereau marked this pull request as ready for review July 1, 2023 11:47
@SamuelMereau SamuelMereau marked this pull request as draft September 16, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants