update quick-install.sh #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Made compatible with any posix shell * Moved command running into a run_cmd function * run_cmd will check the userid and if it's not 0/root, then it will run the command with sudo * This fixes the issue that the script previously would fail for a root user who doesn't have sudo installed and that it's simply unnecessary to run sudo for root user * Moved all commands out of the apt_fast_installation funtion as the function isn't really necessary.
Repository owner
deleted a comment
Feb 23, 2023
Repository owner
locked as spam and limited conversation to collaborators
Feb 23, 2023
|
Thank you so much for your PR. I merged it with c2cd0a0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unnecessary to run sudo for root user
Also, this removes the "sudo bash -c", which unnecessarily starts up another shell