scope skip_before_filter :authenticate to only actions Clearance defi…

…nes. updated CHANGELOG
ilikepi · Feb 15, 2010 · 087b55b · 087b55b
1 parent 6be0f61
commit 087b55b
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 7 deletions.
diff --git a/CHANGELOG.textile b/CHANGELOG.textile
@@ -1,6 +1,8 @@
 h2. 0.8.6 (unreleased)
 
 * Clearance features capitalization should match view text (Bobby Wilson)
+* skip :authenticate before_filter in controllers so apps can easily
+authenticate a whole site without subclassing (Matthew Ford)
 
 h2. 0.8.5 (01/20/2009)
 

diff --git a/README.textile b/README.textile
@@ -104,5 +104,5 @@ h2. Authors
 
 Clearance was extracted out of "Hoptoad":http://hoptoadapp.com. We merged the authentication code from two of thoughtbot's clients' Rails apps and have since used it each time we need authentication. The following people have improved the library. Thank you!
 
-Dan Croak, Mike Burns, Jason Morrison, Joe Ferris, Eugene Bolshakov, Nick Quaranto, Josh Nichols, Mike Breen, Marcel Görner, Bence Nagy, Ben Mabey, Eloy Duran, Tim Pope, Mihai Anca, Mark Cornick, Shay Arnett, Joshua Clayton, Mustafa Ekim, Jon Yurek, Anuj Dutta, and Chad Pytel.
+Dan Croak, Mike Burns, Jason Morrison, Joe Ferris, Eugene Bolshakov, Nick Quaranto, Josh Nichols, Mike Breen, Marcel Görner, Bence Nagy, Ben Mabey, Eloy Duran, Tim Pope, Mihai Anca, Mark Cornick, Shay Arnett, Joshua Clayton, Mustafa Ekim, Jon Yurek, Anuj Dutta, Chad Pytel, Ben Orenstein, Bobby Wilson, and Matthew Ford.
 
diff --git a/app/controllers/clearance/confirmations_controller.rb b/app/controllers/clearance/confirmations_controller.rb
@@ -1,7 +1,7 @@
 class Clearance::ConfirmationsController < ApplicationController
   unloadable
-  
-  skip_before_filter :authenticate
+
+  skip_before_filter :authenticate,                  :only => [:new, :create]
   before_filter :redirect_signed_in_confirmed_user,  :only => [:new, :create]
   before_filter :redirect_signed_out_confirmed_user, :only => [:new, :create]
   before_filter :forbid_missing_token,               :only => [:new, :create]

diff --git a/app/controllers/clearance/passwords_controller.rb b/app/controllers/clearance/passwords_controller.rb
@@ -1,7 +1,7 @@
 class Clearance::PasswordsController < ApplicationController
   unloadable
-  
-  skip_before_filter :authenticate
+
+  skip_before_filter :authenticate,        :only => [:edit, :update]
   before_filter :forbid_missing_token,     :only => [:edit, :update]
   before_filter :forbid_non_existent_user, :only => [:edit, :update]
   filter_parameter_logging :password, :password_confirmation

diff --git a/app/controllers/clearance/sessions_controller.rb b/app/controllers/clearance/sessions_controller.rb
@@ -1,7 +1,7 @@
 class Clearance::SessionsController < ApplicationController
   unloadable
 
-  skip_before_filter :authenticate
+  skip_before_filter :authenticate, :only => [:new, :create, :destroy]
   protect_from_forgery :except => :create
   filter_parameter_logging :password
 

diff --git a/app/controllers/clearance/users_controller.rb b/app/controllers/clearance/users_controller.rb
@@ -1,8 +1,8 @@
 class Clearance::UsersController < ApplicationController
   unloadable
 
-  before_filter :redirect_to_root, :only => [:new, :create], :if => :signed_in?
   skip_before_filter :authenticate, :only => [:new, :create]
+  before_filter :redirect_to_root,  :only => [:new, :create], :if => :signed_in?
   filter_parameter_logging :password
 
   def new