Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node v10.0.0 incompatible module error, upath@1.0.4: The engine "… #11

Closed
wants to merge 1 commit into from

Conversation

raindust
Copy link

…node" is incompatible with this module. Expected version ">=4 <=9".

…node" is incompatible with this module. Expected version ">=4 <=9".
@g1eny0ung
Copy link
Member

This is an annoying problem when you using the yarn command.

But we shouldn't edit the .lock file directly, it's an anti-pattern.

According to anodynos/upath#14:

This is an indirect dependency of webpack (webpack -> watchpack -> chokidar -> upath), so the current engines flag prevents any webpack user from upgrading to node 10.

I will upgrade the related package after soon.

Thx for PR. 👍

g1eny0ung added a commit that referenced this pull request Sep 16, 2018
@g1eny0ung
Copy link
Member

Fixed in f335663.

@raindust
Copy link
Author

Ok, i see: )
This repo is really a good job, and mabe the only active Douban.FM on mac. So let's hold on~

@raindust raindust closed this Sep 17, 2018
@g1eny0ung
Copy link
Member

Thx. @raindust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants