Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Data Loading Within the School Manager #7973

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

jrjohnson
Copy link
Member

By pre-loading more of this data in the route we can do less loading and spinning in the components and significantly reduce the number of network calls required to manage a school.

Followup to #7934

By pre-loading more of this data in the route we can do less loading and
spinning in the components and significantly reduce the number of
network calls required to manage a school.
Since we use a peek record in these components we need to pre-load all
of the tests data into the store before rendering them.
@jrjohnson jrjohnson force-pushed the school-data-loading-improvements branch from 72200dd to 05b2c93 Compare July 17, 2024 03:48
@jrjohnson jrjohnson marked this pull request as ready for review July 17, 2024 05:58
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stopfstedt stopfstedt merged commit e91866b into ilios:master Jul 19, 2024
36 checks passed
@jrjohnson jrjohnson deleted the school-data-loading-improvements branch July 19, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants