Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes some mobile style issues with Calendar route #8020

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fixes some mobile style issues with Calendar route #8020

merged 4 commits into from
Jul 30, 2024

Conversation

michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick commented Jul 30, 2024 •
edited
Loading

  • filter headings now have static height below phone-only cutoff
  • filter content now has some needed padding
  • X AM/PM labels now fit without wrapping in English
  • View and Time pickers now use CSS flexbox so they collapse to column nicely under tablet cutoff

Fixes ilios/ilios#5605

stopfstedt
stopfstedt approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks GREAT To Me.

image

@dartajax dartajax merged commit bdb9d20 into ilios:master Jul 30, 2024
39 checks passed
@michaelchadwick michaelchadwick deleted the frontend-5605-mobile-cal-style-fixes branch July 30, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopfstedt stopfstedt stopfstedt approved these changes

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Assignees

@dartajax dartajax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter columns for Calendar on mobile not uniform height and need padding
3 participants
@michaelchadwick @stopfstedt @dartajax