Hide unpublished info from the ICS feed #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t show anything that isn’t published and display only title and date for scheduled stuff.
| $events = $userHandler->addInstructorsToEvents($userHandler->findEventsForUser($user->getId(), $from, $to)); | ||
|
|
||
| //Only show published events | ||
| $events = array_filter($events, function ($event) { |
There was a problem hiding this comment.
i suggest moving this up. filter out un-published events first before loading/attaching additional data points, such as instructors.
There was a problem hiding this comment.
Good call - refactored a bit to not add details to non-published or scheduled events.
Do this before filtering is a waste as unpublished events get dropped anyway.
stopfstedt
added a commit
that referenced
this pull request
Jan 8, 2016
Hide unpublished info from the ICS feed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t show anything that isn’t published and display only title and
date for scheduled stuff.
Fixes #1235