Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store uploaded files in the shared file system #2845

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Store uploaded files in the shared file system #2845

merged 1 commit into from
Mar 23, 2020

Conversation

jrjohnson
Copy link
Member

Learning materials are uploaded into a temporary file system on whatever
server the user happens to hit. On distributed systems this makes it a
random chance of catching the system which contains the file when you
want to save it.

This change stores these uploaded files on the official FS (S3, shared
drive) which is already setup to be shared among machines. Thus ensuring
that tmp files are available when users want to attach them to a
learning material.

Learning materials are uploaded into a temporary file system on whatever
server the user happens to hit. On distributed systems this makes it a
random chance of catching the system which contains the file when you
want to save it.

This change stores these uploaded files on the official FS (S3, shared
drive) which is already setup to be shared among machines. Thus ensuring
that tmp files are available when users want to attach them to a
learning material.
@jrjohnson jrjohnson marked this pull request as ready for review March 20, 2020 06:59
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stopfstedt stopfstedt merged commit 36d6e45 into ilios:master Mar 23, 2020
@jrjohnson jrjohnson deleted the store-tmp branch March 23, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants