Added PWA manifest file #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shreyas208 can you rebase on master, fix any Prettier errors, and add a Changelog entry? |
shreyas208
force-pushed
the
web-manifest
branch
3 times, most recently
from
8ab610f
to
06a4add
Compare
* Redirect working except between queues * Style changes * Removed a print statement * Fix Prettier Errors * Added returns, directly acceses properties * Add tests for queue redirection middleware * Add changelog entry for old queue redirection
nwalters512
previously approved these changes
Mar 3, 2018
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ with the current date and the next changes should go under a **[Next]** header. | |||
| * Allow course staff to see netids next to student name. ([@genevievehelsel](https://github.com/genevievehelsel) in [#32](https://github.com/illinois/queue/pull/32)) | |||
| * Automatically redirect to a current queue or course page if visiting a closed queue. ([@Muakasan](https://github.com/Muakasan) in [#40](https://github.com/illinois/queue/pull/40)) | |||
| * Rebrand from CS@Illinois Queues to Queues@Illinois. ([@genevievehelsel](https://github.com/genevievehelsel) in [#42](https://github.com/illinois/queue/pull/42)) | |||
| * Add web manifest for "Add to Home Screen" on Android. ([@shreyas208](https://github.com/shreyas208) in [#24](https://github.com/illinois/queue/pull/29)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using "Add to home screen" on an Android device will create a PWA app icon that loads the web app in a standalone Chrome window (separate from Chrome in the app switcher) with CS@Illinois Queues icon and title.
Closes #24