Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PWA manifest file #29

Merged
merged 12 commits into from
Mar 3, 2018
Merged

Added PWA manifest file #29

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
21ee8c3
Added PWA manifest file
shreyas208 Feb 28, 2018
15fd726
Redirect nonexistent queues (#40)
muakasan Mar 2, 2018
44da701
Added Travis build status to README.md
shreyas208 Mar 2, 2018
b3139a6
Fixed manifest tag
shreyas208 Mar 3, 2018
6065037
Add crossOrigin attr for manifest link
shreyas208 Mar 3, 2018
12a9371
Updated color
shreyas208 Mar 3, 2018
baf9c79
Updated name
shreyas208 Mar 3, 2018
0bd4e16
Merge branch 'master' into web-manifest
shreyas208 Mar 3, 2018
d3d393e
Fixed pull number
shreyas208 Mar 3, 2018
b34cad8
Merge branch 'web-manifest' of github.com:illinois/queue into web-man…
shreyas208 Mar 3, 2018
230c6f0
Fixed the fix
shreyas208 Mar 3, 2018
929ecee
Fixed the fix of the fix
shreyas208 Mar 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ with the current date and the next changes should go under a **[Next]** header.
* Allow course staff to see netids next to student name. ([@genevievehelsel](https://github.com/genevievehelsel) in [#32](https://github.com/illinois/queue/pull/32))
* Automatically redirect to a current queue or course page if visiting a closed queue. ([@Muakasan](https://github.com/Muakasan) in [#40](https://github.com/illinois/queue/pull/40))
* Rebrand from CS@Illinois Queues to Queues@Illinois. ([@genevievehelsel](https://github.com/genevievehelsel) in [#42](https://github.com/illinois/queue/pull/42))
* Add web manifest for "Add to Home Screen" on Android. ([@shreyas208](https://github.com/shreyas208) in [#24](https://github.com/illinois/queue/pull/29))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this says #24 but should be #29 ?


## 27 February 2018

Expand Down
6 changes: 6 additions & 0 deletions pages/_document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export default class MyDocument extends Document {
__html: `window.BASE_URL = '${baseUrl}';`,
}
const faviconPath = `${baseUrl}/static/favicon.ico`
const manifestPath = `${baseUrl}/static/manifest.json`
return (
<html lang="en">
<Head>
Expand All @@ -39,6 +40,11 @@ export default class MyDocument extends Document {
integrity="sha384-Zug+QiDoJOrZ5t4lssLdxGhVrurbmBWopoEl+M6BdEfwnCJZtKxi1KgxUyJq13dy"
crossOrigin="anonymous"
/>
<link
rel="manifest"
crossOrigin="use-credentials"
href={manifestPath}
/>
<style>{FontAwesome.dom.css()}</style>
<title>Queues@Illinois</title>
<link rel="icon" href={faviconPath} type="image/png" />
Expand Down
11 changes: 11 additions & 0 deletions static/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "Queues@Illinois",
"short_name": "Queues",
"display": "standalone",
"background_color": "#fff",
"icons": [{
"src": "notif_icon.png",
"sizes": "128x128",
"type": "image/png"
}]
}