Atmire fixes for Jan–Feb, 2016

[alanorth]

Compiled from @rradillen's work on the 5_x-dev branch, rebased on top of the latest 5_x-prod. Has been running on DSpace Test for over a week now. //cc @bram-atmire

[alanorth]

Ok, it seems rebasing the 5_x-dev branch on top of 5_x-prod introduced some strange side effects, ie:

 INFO [org.dspace.servicemanager.DSpaceServiceManager] Shutdown DSpace core service manager
Failed to startup the DSpace Service Manager: failure starting up spring service manager: Error creating bean with name 'AtmireFlywayMigration_CUA4_2015_12_03' defined in URL [jar:file:/home/dspacetest.cgiar.org/webapps/xmlui/WEB-INF/lib/atmire-cua-api-5.1-4.0.24-0.jar!/spring/spring-dspace-addon-cua-database-services.xml]: Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'moduleID' of bean class [org.flywaydb.core.api.migration.atmire.AtmireFlywayMigration]: Bean property 'moduleID' is not writable or has an invalid setter method. Did you mean 'module'?
Failure during filter init: Failed to startup the DSpace Service Manager: failure starting up spring service manager: Error creating bean with name 'AtmireFlywayMigration_CUA4_2015_12_03' defined in URL [jar:file:/home/dspacetest.cgiar.org/webapps/xmlui/WEB-INF/lib/atmire-cua-api-5.1-4.0.24-0.jar!/spring/spring-dspace-addon-cua-database-services.xml]: Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'moduleID' of bean class [org.flywaydb.core.api.migration.atmire.AtmireFlywayMigration]: Bean property 'moduleID' is not writable or has an invalid setter method. Did you mean 'module'?:java.lang.RuntimeException: Failed to startup the DSpace Service Manager: failure starting up spring service manager: Error creating bean with name 'AtmireFlywayMigration_CUA4_2015_12_03' defined in URL [jar:file:/home/dspacetest.cgiar.org/webapps/xmlui/WEB-INF/lib/atmire-cua-api-5.1-4.0.24-0.jar!/spring/spring-dspace-addon-cua-database-services.xml]: Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'moduleID' of bean class [org.flywaydb.core.api.migration.atmire.AtmireFlywayMigration]: Bean property 'moduleID' is not writable or has an invalid setter method. Did you mean 'module'?

Building and running 5_x-dev itself works, though, which is strange. I was trying to avoid merging the 5_x-dev branch into 5_x-prod because it's really messy with merge commits and the history is confusing.

Maybe I should actually wait for a proper pull request, @bram-atmire?

[rradillen]

The usual suspect: DSpace doesn't properly clear spring files on rebuild if they have been deleted. Remove /config/spring and redeploy to fix. (hint scripts/build/deploy.sh will spare you the full maven build)

[alanorth]

Ah, great. My git-fu is strong, but Tomcat / Java are very foreign to me. 👍 I'll try that later this afternoon.

[alanorth]

Ok, I removed the /config/spring directory and re-deployed but Tomcat's still throwing errors.

[alanorth]

I have sequentially cherry picked each commit above into a clean branch based off our production branch (5_x-prod) and tested, and it seems like the reset pom commit is the one that causes the problem. I made sure to remove config/spring/ before deploy.

That commit decreases the atmire-dspace-api module version from 5.1-1.15.9-0 to 5.1-1.15.6-0 anyways. Is this important? I'd rather not merge the whole 5_x-dev branch into our production branch because it's messy as hell.

[alanorth]

Ok, I tried to just merge the 5_x-dev branch into our 5_x_prod branch (which is what I've been trying to avoid all along) and after deploy I get a blank, white page. I had manually deleted dspace/config/spring before ant update, as suggested by @rradillen.

Tomcat's catalina log shows:

Failed to startup the DSpace Service Manager: failure starting up spring service manager: Error creating bean with name 'AtmireFlywayMigration_CUA4_2015_12_03' defined in URL [jar:file:/Users/aorth/dspace/webapps/rest/WEB-INF/lib/atmire-cua-api-5.1-4.0.24-0.jar!/spring/spring-dspace-addon-cua-database-services.xml]: Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'moduleID' of bean class [org.flywaydb.core.api.migration.atmire.AtmireFlywayMigration]: Bean property 'moduleID' is not writable or has an invalid setter method. Did you mean 'module'?
Failure during filter init: Failed to startup the DSpace Service Manager: failure starting up spring service manager: Error creating bean with name 'AtmireFlywayMigration_CUA4_2015_12_03' defined in URL [jar:file:/Users/aorth/dspace/webapps/rest/WEB-INF/lib/atmire-cua-api-5.1-4.0.24-0.jar!/spring/spring-dspace-addon-cua-database-services.xml]: Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'moduleID' of bean class [org.flywaydb.core.api.migration.atmire.AtmireFlywayMigration]: Bean property 'moduleID' is not writable or has an invalid setter method. Did you mean 'module'?:java.lang.RuntimeException: Failed to startup the DSpace Service Manager: failure starting up spring service manager: Error creating bean with name 'AtmireFlywayMigration_CUA4_2015_12_03' defined in URL [jar:file:/Users/aorth/dspace/webapps/rest/WEB-INF/lib/atmire-cua-api-5.1-4.0.24-0.jar!/spring/spring-dspace-addon-cua-database-services.xml]: Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'moduleID' of bean class [org.flywaydb.core.api.migration.atmire.AtmireFlywayMigration]: Bean property 'moduleID' is not writable or has an invalid setter method. Did you mean 'module'?

Seems there is really something wrong with the code in this branch...?

[alanorth]

Closed in favor of #195.