dspace-services: Disable update check in ehcache #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some DSpace components rely on an upstream project called Ehcache which has the unfortunate policy of calling home to check if there are any updates every time it is invoked. The update call includes lots of information about the server environment, including the OS and Java versions, and of course the IP address of the server. In addition to this being a jarring leak of privacy, it is also not very effective, as the DSpace user is not in control of the version of Ehcache being used! Furthermore, some parts of the DSpace code will invoke this code hundreds of times, for example in AIP ingest, and it's mind boggling that there should be a call to what amounts to be a random server on the Internet (as far as the DSpace site's owner is concerned). There is an issue on the upstream project's bug tracker where they have said they will not fix it, so we will just disable it locally. See: https://jira.terracotta.org/jira/browse/EHC-461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DSpace components rely on an upstream project called Ehcache which has the unfortunate policy of calling home to check if there are any updates every time it is invoked. The update call includes lots of information about the server environment, including the OS and Java versions, and of course the IP address of the server.
In addition to this being a jarring leak of privacy, it is also not very effective, as the DSpace user is not in control of the version of Ehcache being used! Furthermore, some parts of the DSpace code will invoke this code hundreds of times, for example in AIP ingest, and it's mind boggling that there should be a call to what amounts to be a random server on the Internet (as far as the DSpace site's
owner is concerned).
There is an issue on the upstream project's bug tracker where they have said they will not fix it, so we will just disable it locally.
See: https://jira.terracotta.org/jira/browse/EHC-461