refactor: #1012 - Resolve Sonar report: missing assertions in several…

… AppTest classes (#1784) Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
iluwatar · Jun 7, 2021 · 43e7ca5 · 43e7ca5
1 parent f6d4397
commit 43e7ca5
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 21 deletions.
diff --git a/filterer/src/test/java/com/iluwatar/filterer/AppTest.java b/filterer/src/test/java/com/iluwatar/filterer/AppTest.java
@@ -23,11 +23,14 @@
 
 package com.iluwatar.filterer;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 class AppTest {
+
   @Test
   void shouldLaunchApp() {
-    App.main(new String[]{});
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/monad/src/test/java/com/iluwatar/monad/AppTest.java b/monad/src/test/java/com/iluwatar/monad/AppTest.java
@@ -23,16 +23,19 @@
 
 package com.iluwatar.monad;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
  * Application Test
  */
-public class AppTest {
+
+class AppTest {
 
   @Test
-  void testMain() {
-    App.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 
 }
diff --git a/monostate/src/test/java/com/iluwatar/monostate/AppTest.java b/monostate/src/test/java/com/iluwatar/monostate/AppTest.java
@@ -23,16 +23,19 @@
 
 package com.iluwatar.monostate;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
  * Application Test Entry
  */
-public class AppTest {
+
+class AppTest {
 
   @Test
-  void testMain() {
-    App.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 
 }
diff --git a/multiton/src/test/java/com/iluwatar/multiton/AppTest.java b/multiton/src/test/java/com/iluwatar/multiton/AppTest.java
@@ -23,15 +23,18 @@
 
 package com.iluwatar.multiton;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
- * Application test
+ * Test if the application starts without throwing an exception.
  */
-public class AppTest {
+
+class AppTest {
 
   @Test
-  void test() {
-    App.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/object-pool/src/test/java/com/iluwatar/object/pool/AppTest.java b/object-pool/src/test/java/com/iluwatar/object/pool/AppTest.java
@@ -23,6 +23,8 @@
 
 package com.iluwatar.object.pool;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
@@ -34,6 +36,6 @@ class AppTest {
 
   @Test
   void shouldExecuteApplicationWithoutException() {
-    App.main(new String[]{});
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java b/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java
@@ -23,19 +23,16 @@
 
 package com.iluwatar.parameter.object;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Application test
  */
 class AppTest {
-  private static final Logger LOGGER = LoggerFactory.getLogger(AppTest.class);
-
   @Test
   void shouldExecuteApplicationWithoutException() {
-    App.main(new String[]{});
-    LOGGER.info("Executed successfully without exception.");
+    assertDoesNotThrow(() -> App.main(new String[]{}));
   }
 }
diff --git a/saga/src/test/java/com/iluwatar/saga/orchestration/SagaApplicationTest.java b/saga/src/test/java/com/iluwatar/saga/orchestration/SagaApplicationTest.java
@@ -23,15 +23,17 @@
 
 package com.iluwatar.saga.orchestration;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
 import org.junit.jupiter.api.Test;
 
 /**
- * empty test
+ * Test if the application starts without throwing an exception.
  */
 class SagaApplicationTest {
 
   @Test
-  void mainTest() {
-    SagaApplication.main(new String[]{});
+  void shouldExecuteApplicationWithoutException() {
+    assertDoesNotThrow(() -> SagaApplication.main(new String[]{}));
   }
 }