#1012 - Resolve Sonar report: missing assertions in several AppTest c… #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
ohbus
reviewed
Jun 7, 2021
| @Test | ||
| void shouldExecuteApplicationWithoutException() { | ||
| App.main(new String[]{}); | ||
| LOGGER.info("Executed successfully without exception."); |
There was a problem hiding this comment.
Any reasons for removing logging? Was it showing any issues on sonar?
There was a problem hiding this comment.
The purpose of the logging was to assert that the code executed without errors. Since there is an aproprieted assertion for that, there is no need for this logging.
ohbus
approved these changes
Jun 7, 2021
|
@all-contributors please add @samuelpsouza for code |
|
I've put up a pull request to add @samuelpsouza! 🎉 |
RobbiNespu
pushed a commit
to RobbiNespu/java-design-patterns
that referenced
this pull request
Mar 1, 2022
… several AppTest classes (iluwatar#1784) Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve part of issue #1012
Some blocking issues found in the Sonar report are related to the lack of assertions in AppTest classes. The changes provide those assertions. Also, a few methods were renamed to a more precise name.