Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2377: The repository code has been refactored to use the recor… #2505

Merged
merged 4 commits into from
May 6, 2023

Conversation

MugheesQasim
Copy link
Contributor

…d class

Pull request description

  • The immutable classes are replaced with the record classes (Java 16)
  • There are some other classes in the codebase which have private final fields but I was not sure whether converting them to record classes would provide any significant benefit

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.9% 87.9% Coverage
0.0% 0.0% Duplication

@iluwatar iluwatar merged commit 3ae6b07 into iluwatar:master May 6, 2023
1 check passed
@iluwatar
Copy link
Owner

iluwatar commented May 6, 2023

Looks good! Thank you for the contribution 🎉

@iluwatar
Copy link
Owner

iluwatar commented May 6, 2023

@all-contributors please add @MugheesQasim for code

@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @MugheesQasim! 🎉

kongleong86 pushed a commit to kongleong86/java-design-patterns that referenced this pull request Oct 2, 2023
…ored to use the recor… (iluwatar#2505)

* Issue iluwatar#2377: The repository code has been refactored to use the record class

* Issue iluwatar#2377: Refactored according to the rules defined for the repo code

* Issue iluwatar#2377: Refactored according to the rules defined for the repo code

* Issue iluwatar#2377: Refactored according to the rules defined for the repo code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants