Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: GH actions pre-commit.ci fails on code base errors. #50

Closed
imAsparky opened this issue Sep 5, 2021 · 1 comment
Closed

[BUG]: GH actions pre-commit.ci fails on code base errors. #50

imAsparky opened this issue Sep 5, 2021 · 1 comment
Assignees
@imAsparky
Labels
bug Something isn't working
Projects
Modify the original fork to suit my n...

Comments

@imAsparky
Copy link
Owner

Describe the bug
A clear and concise description of what the bug is.

cookiecutter>=1.4.0 in requirements_dev.txt was causing the pre-commit hook - id: python-safety-dependencies-check
to fail when GitHub actions.

To Reproduce
Steps to reproduce the behavior:

Locally, the action below had not been included in the pre-commit yaml file, so there was no failure when running the pre-commit.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

image

Desktop (please complete the following information):

  • imAsparky cookiecutter-pypackage version:
  • Python version:
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@imAsparky imAsparky added the bug Something isn't working label Sep 5, 2021
@imAsparky imAsparky self-assigned this Sep 5, 2021
@imAsparky imAsparky added this to To do in Modify the original fork to suit my needs via automation Sep 5, 2021
@imAsparky imAsparky changed the title [BUG]: GH actions pre-commit fails on unpinned requirem [BUG]: GH actions pre-commit fails on unpinned requirement. Sep 5, 2021
imAsparky added a commit that referenced this issue Sep 5, 2021
@imAsparky
fix(pre-commit): Fail unpinned dependency #50
29c8927 
Locally, the action below had not been included in the pre-commit yaml
file; therefore, no failure occurred when running the pre-commit.
 - repo: https://github.com/Lucas-C/pre-commit-hooks-safety
      rev: v1.2.1
      hooks:
          - id: python-safety-dependencies-check

Update local pre-commit test suite with  - id: python-safety-dependencies-check.
Pin requirements_dev.txt cookiecutter==1.4.0.

closes #50
imAsparky added a commit that referenced this issue Sep 6, 2021
@imAsparky
fix(pre-commit): Comment out safety-dev-chk #50
93d2b7b 
The pre-commit.ci action is still failing. I have commented the check
below out to see if the new failure stops.

 - repo: https://github.com/Lucas-C/pre-commit-hooks-safety
       rev: v1.2.1
       hooks:
           - id: python-safety-dependencies-check

WIP #50
@imAsparky
Copy link
Owner Author

I'm opening a new issue branch to work through all the pre-commit errors in the code base.

@imAsparky imAsparky changed the title [BUG]: GH actions pre-commit fails on unpinned requirement. [BUG]: GH actions pre-commit.ci fails on code base errors. Sep 6, 2021
imAsparky added a commit that referenced this issue Sep 6, 2021
@imAsparky
fix(pre-com): Comment out safety-dep-chk #50
54dda82 
The pre-commit.ci action is still failing. I have commented the check
below out to see if the new failure stops.

 - repo: https://github.com/Lucas-C/pre-commit-hooks-safety
       rev: v1.2.1
       hooks:
           - id: python-safety-dependencies-check

WIP #50
@imAsparky imAsparky mentioned this issue Sep 6, 2021
Merged
imAsparky added a commit that referenced this issue Sep 6, 2021
@imAsparky
fix(pre-com): Fix unknown escape character #50
7a3c023 
Add an escape character to fix yaml check failure.

WIP #50
imAsparky added a commit that referenced this issue Sep 6, 2021
@imAsparky
fix(pre-com): Fix pre-commit errors #50
f36f91c 
Some code that did not pass pre-commit checks existed.
All pre-commit tests passed locally.

closes #50
imAsparky added a commit that referenced this issue Sep 6, 2021
@imAsparky
fix(pre-com): Comment out safety-dep-chk #50
19d4ea2 
The pre-commit.ci action is still failing. I have commented the check
below out to see if the new failure stops.
 - repo: https://github.com/Lucas-C/pre-commit-hooks-safety
       rev: v1.2.1
       hooks:
           - id: python-safety-dependencies-check

WIP #50
imAsparky added a commit that referenced this issue Sep 6, 2021
@imAsparky
fix(codacy): Docstrings comply with PEP257 #50
d8bbe8a 
Several docstrings failed Codacy production tests as not complying
with PEP257.

WIP #50
imAsparky added a commit that referenced this issue Sep 6, 2021
@imAsparky
fix(codacy): More docstrings comply PEP257 #50
a79a24f 
Several additional  docstrings failed Codacy production tests as not
complying with PEP257.

WIP #50
Modify the original fork to suit my needs automation moved this from To do to Done Sep 6, 2021
@imAsparky imAsparky mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imAsparky imAsparky

Labels
bug Something isn't working
Projects
Modify the original fork to suit my n...
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imAsparky