Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pre-com): Fix pre-commit errors #50 #51

Merged
merged 8 commits into from Sep 6, 2021
Merged

fix(pre-com): Fix pre-commit errors #50 #51

merged 8 commits into from Sep 6, 2021

Conversation

imAsparky
Copy link
Owner

The pre-commit.ci action is still failing. I have commented the check
below out to see if the new failure stops.

WIP #50

imAsparky and others added 7 commits September 6, 2021 06:00
The pre-commit.ci action is still failing. I have commented the check
below out to see if the new failure stops.

 - repo: https://github.com/Lucas-C/pre-commit-hooks-safety
       rev: v1.2.1
       hooks:
           - id: python-safety-dependencies-check

WIP #50
Add an escape character to fix yaml check failure.

WIP #50
Some code that did not pass pre-commit checks existed.
All pre-commit tests passed locally.

closes #50
The pre-commit.ci action is still failing. I have commented the check
below out to see if the new failure stops.
 - repo: https://github.com/Lucas-C/pre-commit-hooks-safety
       rev: v1.2.1
       hooks:
           - id: python-safety-dependencies-check

WIP #50
Several docstrings failed Codacy production tests as not complying
with PEP257.

WIP #50
@imAsparky imAsparky changed the title fix(pre-com): Comment out safety-dep-chk #50 fix(pre-com): fix(pre-com): Fix pre-commit errors #50 Sep 6, 2021
@imAsparky imAsparky changed the title fix(pre-com): fix(pre-com): Fix pre-commit errors #50 fix(pre-com): Fix pre-commit errors #50 Sep 6, 2021
Several additional  docstrings failed Codacy production tests as not
complying with PEP257.

WIP #50
@imAsparky imAsparky merged commit 9360c7f into main Sep 6, 2021
@imAsparky imAsparky deleted the issue-50 branch September 6, 2021 11:40
@imAsparky imAsparky linked an issue Sep 6, 2021 that may be closed by this pull request
@imAsparky imAsparky self-assigned this Sep 15, 2021
@imAsparky imAsparky added the bug Something isn't working label Sep 15, 2021
@imAsparky imAsparky added this to In progress in Modify the original fork to suit my needs via automation Sep 15, 2021
@imAsparky imAsparky moved this from In progress to Done in Modify the original fork to suit my needs Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add pre-commit and sensible configurations.
1 participant