Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-10 Change command permission structure #11

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

imDMK
Copy link
Owner

@imDMK imDMK commented Oct 13, 2023

Fixes #10
This PR changes command structures:

  • Command permissions are no longer configurable - They are permanently set.

List of command permissions:

  • /spenttime: command.spenttime
  • /spenttime {TARGET}: command.spenttime.other
  • /spenttime top: command.spenttime.top
  • /spenttime reset: command.spenttime.reset
  • /spenttime reset-all: command.spenttime.reset.all
    The change is because if permissions were still configurable, it would not be possible to configure a separate permission for /spenttime {TARGET}.

@imDMK imDMK added the enhancement New feature or request label Oct 13, 2023
@imDMK imDMK force-pushed the change-command-permissions-structure branch from 3592335 to 7f82653 Compare October 13, 2023 21:58
@SpLeNd1d222
Copy link

Commands are good and they are more important than permissions, so if it is not possible to leave the possibility to change them, so be it. And now it means that every player group, including the default, will have access to these commands, right?

@imDMK
Copy link
Owner Author

imDMK commented Oct 14, 2023

Commands are good and they are more important than permissions, so if it is not possible to leave the possibility to change them, so be it. And now it means that every player group, including the default, will have access to these commands, right?

No. This means that by default a player without permissions will not be able to execute the spenttime command. To execute the command, it must have the specified permissions that I wrote above.

@imDMK
Copy link
Owner Author

imDMK commented Oct 14, 2023

Only the permissions have been changed - they are no longer editable, but permanently assigned to the command.
Let me know what you think about them.

@imDMK imDMK merged commit c59b082 into main Oct 15, 2023
2 checks passed
@imDMK imDMK deleted the change-command-permissions-structure branch October 15, 2023 10:44
@SpLeNd1d222
Copy link

Ooh, so now everything is okay, just like I expected how commands and permissions would be. I thought that if I can't configure them, I can't assign particular command permission to a particular group, but that's not the case as I can see and I don't know why would anyone need to edit permissions xd Everything's cool now, thanks for these changes!

@imDMK
Copy link
Owner Author

imDMK commented Oct 16, 2023

No problem!
Thank you for using the plugin.

if you are interested in my plugins you can also check out the double jump plugin:
https://github.com/imDMK/DoubleJump

@SpLeNd1d222
Copy link

I have one more question, what's the permission for the /spenttime target command, because here it says it's command.spenttime.other but for example in #17 i noticed that it says it's command.spenttime.target. So how is it?

@imDMK
Copy link
Owner Author

imDMK commented Oct 16, 2023

Yeah, I decided to change this permission to command.spenttime.target

@imDMK
Copy link
Owner Author

imDMK commented Oct 16, 2023

On the main page https://github.com/imDMK/SpentTime you have actual information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to change permissions of all commands
2 participants