-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new image processing function (contrast stretch). #635
Adding new image processing function (contrast stretch). #635
Conversation
…pired by OpenCV library.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## legacy #635 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 163 163
Lines 5698 5698
Branches 1424 1424
=======================================
Hits 4811 4811
Misses 790 790
Partials 97 97 ☔ View full report in Codecov by Sentry. |
@targos, @lpatiny, @stropitek, @JulDenereaz, I have raised one PR, please check, it is running fine on every other version except (12.x). |
This comment was marked as resolved.
This comment was marked as resolved.
There is no need to ping everyone, people like me who are watching the project will get notified even if you don't. I think to justify adding this to image-js, it has to be a standard algorithm with a standard name. From what I see it's not based on the opencv library but on an opencv tutorial. I think "contrast stretching" is a generic term used for any method that widens the range of values used by the image's pixels but it could be anything, including non-linear stretching. Therefore I am not in favor of adding this to image-js. |
@stropitek, pardon me, about the function name, I shall make the changes accordingly. |
@stropitek, Isn't "linearContrastStretch" a more descriptive name that explicitly mentions contrast stretching in a linear manner, or we can use "convertScaleAbs" as openCV. (If you have any other name suggestion, kindly mention). |
@stropitek, a gentle reminder. |
I think that as is the case for opencv, this should be in a tutorial rather than in the API of image-js, because it is too specific and can already be done in a few lines of code with the current API. Thank you for your willingness to contribute, I'm closing the PR. |
Hi Daniel,
What do you mean by tutorial? Please elaborate.
Just leave opencv aside, I want to improve this ImageJS library (I have a
few more image processing functions, which are not there in ImageJS, please
guide me.
Thank you.
…On Tue, 19 Mar 2024 at 18:56, Daniel Kostro ***@***.***> wrote:
I think that as is the case for opencv, this should be in a tutorial
rather than in the API of image-js, because it is too specific and can
already be done in a few lines of code with the current API.
Thank you for your understanding, I'm closing the PR.
—
Reply to this email directly, view it on GitHub
<#635 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDCQU56UQPHSVCXMSTALYKDYZA4IRAVCNFSM6AAAAABEC5JNJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBXGE3TIMJRG4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
which is inspired by OpenCV library.