Allow -Z minimal-versions to fail #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicKatora
force-pushed
the
minimal-version-failure
branch
from
74c7a00
to
9ac9385
Compare
The actual build fails already (hence it was disabled by a scripted if). With these changes, the build is ran but allowed it to fail. In its current state, minimal versions can at most give an indication on the health of our dependencies but is not required (as indicated by the disabled build). Since this is also prone to the most failures from nightly, it has only little bearing on the decision of merging a PR and releases. The standard nightly target is still enabled regardless.
HeroicKatora
force-pushed
the
minimal-version-failure
branch
from
9ac9385
to
f5597a8
Compare
|
Clarification: If |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual build fails already (hence it was disabled by a scripted if).
With these changes, the build is ran but allowed it to fail. In its
current state, minimal versions can at most give an indication on the
health of our dependencies but is not required (as indicated by the
disabled build). Since this is also prone to the most failures from
nightly, it has only little bearing on the decision of merging a PR and
releases. The standard nightly target is still enabled regardless.