Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to quick-error #67

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Switch to quick-error #67

merged 3 commits into from
Apr 21, 2024

Conversation

fintelia
Copy link
Contributor

@fintelia fintelia commented Apr 21, 2024

Fixes #66

Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, for a pure macro_rules macro this is surprisingly nice. I'm seriouly considering using that in private projects, thanks for the pointer @kornelski.

src/lib.rs Show resolved Hide resolved
@fintelia fintelia merged commit 19e478f into image-rs:main Apr 21, 2024
8 checks passed
@fintelia fintelia deleted the quick-error branch April 22, 2024 03:19
@CryZe
Copy link

CryZe commented May 6, 2024

Nice, this reduced the clean release build compile times of my crate from 23s to 14s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing thiserror
3 participants