Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDecoderExt is named incorrectly #1046

Closed
HeroicKatora opened this issue Sep 29, 2019 · 0 comments · Fixed by #1611
Closed

ImageDecoderExt is named incorrectly #1046

HeroicKatora opened this issue Sep 29, 2019 · 0 comments · Fixed by #1611

Comments

@HeroicKatora
Copy link
Member

HeroicKatora commented Sep 29, 2019

Lifting this from this review which discussed some changes to the ImageDecoder. One thing that came up was that efficient decoding of parts of an image is not particularly ergonomic to use nor to implement. The name of the trait ImageDecoderExt also obscures the fact that it is used for this purpose.

The typical *Ext naming is for traits that purely extend an interface and are implementation for all T: BaseTrait, so this is also a confusing naming.

This is a very good point. Any ideas for alternate names? Perhaps ImageDecoderSeekable or something?

ImageSeek may be a bit terse but not inaccurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant