Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ImageDecoderExt #1611

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Rename ImageDecoderExt #1611

merged 3 commits into from
Nov 15, 2021

Conversation

HeroicKatora
Copy link
Member

@HeroicKatora HeroicKatora commented Nov 13, 2021 •
edited
Loading

Closes: #1046

Since there is no way to introduce aliases for traits we must do this in a major change, and can't have a backwards compatible, hidden way for migration.

@HeroicKatora HeroicKatora mentioned this pull request Nov 13, 2021
Closed
22 tasks
@fintelia
Copy link
Contributor

If we were willing to make all ImageDecoder's require a Seek bound from their inner readers, then we could merge the two traits. Otherwise 👍 on renaming ImageDecodeExt -> ImageDecoderRect in the 0.24 release

@HeroicKatora
Copy link
Member Author

Even with the Seek bound it would still be additional functionality to implement. I suppose one could make a somewhat complex system to make it optional, however this might be convoluted.

@fintelia fintelia merged commit 69e686a into image-rs:master Nov 15, 2021
@HeroicKatora HeroicKatora deleted the breaking-interface-names branch November 15, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageDecoderExt is named incorrectly
2 participants
@HeroicKatora @fintelia