Align travis build to actions #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failure that occurs only on nightly seems to be more often due to Rust breakage than a bug. Take deprecation warnings more serious by actively denying them which warns us of incompatible future versions as nightly would. Note: May remove this again in the future if it doesn't help. We've already had the case where the rustc version commitment left us without a proper replacement for a while since that had only been introduce shortly before deprecation. Also ensures that tests are ran on all relevant builds instead of only on nightly.
For osx and windows targets build with the first env combination since they are matrix includes. This ensures that this selects the build script with default features instead of no features.
HeroicKatora
force-pushed
the
build-system
branch
from
3220ece
to
f0bef52
Compare
|
Does it resolve #1043? |
|
Yes it should. Thank you for noting. |
HeroicKatora
commented
Oct 1, 2019
HeroicKatora
force-pushed
the
build-system
branch
from
d64eeb3
to
f4bb180
Compare
Checks if a variable was declared, not if it has a non-empty content.
The core operation `${VARNAME+word}` will equal `word` if `VARNAME` is
set and non-null and be empty otherwise.
```
DEFAULT_FEATURES=''
[ -z "$DEFAULT_FEATURES" ] # true
```
```
DEFAULT_FEATURES=''
[ -n "${DEFAULT_FEATURES+exists}" ] # false
```
HeroicKatora
force-pushed
the
build-system
branch
from
f4bb180
to
5a03954
Compare
JohnTitor
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure that occurs only on nightly seems to be more often due to Rust
breakage than a bug. Take deprecation warnings more serious by actively
denying them which warns us of incompatible future versions as nightly
would.
Note: May remove this again in the future if it doesn't help. We've
already had the case where the rustc version commitment left us
without a proper replacement for a while since that had only been
introduce shortly before deprecation.
Also ensures that tests are ran on all relevant builds instead of only
on nightly.
Closes: #1043