Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display multiple images implementation, some minor fixes #307

Merged
merged 26 commits into from
Jan 22, 2019
Merged

Display multiple images implementation, some minor fixes #307

merged 26 commits into from
Jan 22, 2019

Commits on Jan 8, 2019

  1. updating dependencies and features and added window module

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    b5b931c View commit details
    Browse the repository at this point in the history

  2. added entire field for sdl2

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    e9d20ef View commit details
    Browse the repository at this point in the history

  3. fixed some issues in cargo.toml and removed some useless code in wind… 

    …ow.rs
    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    eaaf59f View commit details
    Browse the repository at this point in the history

  4. fixed typo in toml

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    7c7ea87 View commit details
    Browse the repository at this point in the history

  5. made dispay_image public

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    1ca16d8 View commit details
    Browse the repository at this point in the history

  6. tidied up window module and cargo.toml

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    9bea1e0 View commit details
    Browse the repository at this point in the history

  7. display_image can now only take positive window dimension arguments

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    b9ba803 View commit details
    Browse the repository at this point in the history

  8. fixed some type issues and logical errors with window dimensions in e… 

    …vent loop
    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    cf75fef View commit details
    Browse the repository at this point in the history

  9. added cfg for feature display-window

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    2714ada View commit details
    Browse the repository at this point in the history

  10. added some doc comments, code comments, and cleaned up some unnecessa… 

    …ry code
    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    090d561 View commit details
    Browse the repository at this point in the history

  11. fixed comment concerning get_output_image

    @arthmis
    arthmis committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    a4d75f2 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. accidentally erased canvas.present(), now added it back to resize event

    @arthmis
    arthmis committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    8dc6fc9 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2019

  1. trying to simplify the code

    @arthmis
    arthmis committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    f567d4f View commit details
    Browse the repository at this point in the history

  2. fixing some problems

    @arthmis
    arthmis committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    4ffa6d3 View commit details
    Browse the repository at this point in the history

  3. fixed a brackets issue

    @arthmis
    arthmis committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    d49dbf6 View commit details
    Browse the repository at this point in the history

  4. fixed up the code

    @arthmis
    arthmis committed Jan 10, 2019
    Configuration menu
    Copy the full SHA
    cfbd0f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2019

  1. added suggested review fixes

    @arthmis
    arthmis committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    9661f14 View commit details
    Browse the repository at this point in the history

  2. ran rustfmt

    @arthmis
    arthmis committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    e67b3eb View commit details
    Browse the repository at this point in the history

  3. mentioned minimum window size in docs

    @arthmis
    arthmis committed Jan 13, 2019
    Configuration menu
    Copy the full SHA
    87039b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. adopted changes from upstream

    @arthmis
    arthmis committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    74c81de View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. attempting to display multiple windows, currently giving signa SIGSEG… 

    …V (Address boundary error)
    @arthmis
    arthmis committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    5c3cff2 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2019

  1. display multiple images 

    * working on multiple image displays in a new branch

* managed to open two windows without resizing events working

* got most of the logic working, now have to figure out how to quit out application after closing all windows one by one

* trying to work with sdl2_sys window flags

* ran rustfmt, implemented multiple image displays, added empire state building jpeg
    @arthmis
    arthmis committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    e56f099 View commit details
    Browse the repository at this point in the history

  2. implemented display_image using display_multiple_images

    @arthmis
    arthmis committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    e81301a View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. added suggested fixes, renamed multiple_image_displays.rs to display_… 

    …multiple_images.rs
    @arthmis
    arthmis committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    ebe4c86 View commit details
    Browse the repository at this point in the history

  2. removed multiple_image_displays.rs

    @arthmis
    arthmis committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    008f4ac View commit details
    Browse the repository at this point in the history

  3. updated doc comments for display_multiple_images.rs

    @arthmis
    arthmis committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    1bf46ca View commit details
    Browse the repository at this point in the history