browser support #385
Merged
browser support #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for tackling this, and sorry for the delays. I'll try to review the PR this week. |
netroy
reviewed
Jun 19, 2023
refactor: split out index into separate files for easier node and browser support tests: make sure tests pass again chore: use node: style imports breaking: removed fs support on types/interface.ts build: adjusted exports to work with node and node16 resolution modes style: adjusted prettier quotes to match eslint Co-authored-by: mcdenhoed <mcdenhoed@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
netroy
pushed a commit
that referenced
this pull request
Nov 13, 2023
refactor: split out index into separate files for easier node and browser support tests: make sure tests pass again chore: use node: style imports breaking: removed fs support on types/interface.ts build: adjusted exports to work with node and node16 resolution modes style: adjusted prettier quotes to match eslint Co-authored-by: mcdenhoed <mcdenhoed@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds browser support as part of #384. As a result, the use of
fswas dropped from index.ts and moved over to a dedicatednode.tsfile.Other notable changes include:
As part of this I manually tested installing the package on a esm project and a non esm project as well as testing on node and the browser and they both seem to fully work.
I'm targeting 2.0 since it seems like the right branch to introduce small API breaking changes. I'm open to ideas and suggestions, or thoughts going forward.