BUG: Support compression and compressionargs in tifffile plugin
#894
Conversation
| DeprecationWarning, | ||
| ) | ||
|
|
||
| if _tifffile.__version__ < "2022": |
There was a problem hiding this comment.
Does that mean there's no any version using compress?
There was a problem hiding this comment.
Yes. compress was used at some point to facilitate compression and while I didn't check the version of tifffile where this change happened, it has been deprecated for at least one year.
| @@ -191,6 +191,8 @@ | |||
| "resolution", | |||
| "description", | |||
| "compress", | |||
| "compression", | |||
There was a problem hiding this comment.
Is that all? Maybe we can add the entire set of new args they currently have?
There was a problem hiding this comment.
We could; although we would also have to also document those new kwargs. I would much rather spend that time on writing a v3 plugin for tifffile. That would also solve the problem of reoccurring maintenance costs for keeping the plugin in sync.
Speaking off documentation, I just noticed that I forgot to add documentation for compression and compressionargs ... will do :)
There was a problem hiding this comment.
IMHO undocumented feature is still better than not working, so if I'm doing it I would probably just copy-paste their arg list here. But anyway, my issue is resolved so will let someone else to worry about the rest.
Closes: #893
This PR adds a
metadatakwarg to the LegacyPlugin, which allows passing metadata to a format'sappend_datafunction. It also adds support for the (not so) new kwargscompressionandcompressionargswhich tifffile has introduced to manage compression. Among other things, these changes make it possible to use TIFF compression in the v3 API.