Fix the issue when Window menu items are not removed upon closing images #30
Conversation
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Due to the scheme that sees versions like 1.49c13 before 1.49c, let alone 1.49 final, a simple String comparison is unfortunately not good enough. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The ij1-patcher has to work with a wide range of ImageJ 1.x versions. The reason is simple: every once in a while, previously working plugins stop working because ImageJ 1.x development is not *quite* as backwards-compatible as it could be. In such cases, users are basically stuck with older versions, leading to the famous 'ImageJ icon gallery' on the desktop. Sometimes ImageJ 1.x changes crucially so that completely different fixes are needed for different versions. To that end, we introduce a function that lets you verify that the current ImageJ 1.x version is at least the specified one, for conditional patching. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When ImageJ 1.x adds images to the Window menu, it does not care whether there were already some plugin installed or not; it always appends the new menu item. Instead, it should insert the correct position. This fixes imagej/imagej-legacy#68. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
@ctrueden I am not quite sure whether it is appropriate to call |
I think that is completely appropriate, and the intended way to append to an AWT menu.
As an aside, in case you didn't know, you can convert a vanilla issue into a pull request using the GitHub API. 😁 Anyway, in my tests, this patch fixes the Window menu problems. However, it does not address another bug: closing and reopening the same image results in In any case, regarding this PR: LGTM! 👍 |
Fix the issue when Window menu items are not removed upon closing images
|
Thanks for the tip with converting issues into pull requests (although that would not apply here because I originally thought it was an And thanks for the reminder regarding the suffixes. I will investigate. |
The problem is actually that ImageJ 1.x gets confused when adding new items, putting them into the wrong spot (when plugins were installed into the
Windowmenu). As a consequence wrong menu items are removed when closing images.In addition to the fix, the changes also include a new API to allow for conditional patching, contingent on ImageJ 1.x version ranges. The reason for this change is that this developer anticipates ImageJ 1.x to be changed in a way that breaks
ij1-patcher. When that happens, we can make use of the new API to unbreak it quickly.This pull request addresses and supersedes imagej/imagej-legacy#68.