Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegacyUI: use IJ1's dialogs for opening and saving #58

Merged
merged 1 commit into from Jun 13, 2014

Conversation

ctrueden
Copy link
Member

This is more consistent with the legacy IJ1 experience. It will also
respect the value of the "Use JFileChooser to open/save" setting,
whereas the previous code always used JFileChooser which is
nigh-unusable on OS X.

See also:
http://fiji.sc/bugzilla/show_bug.cgi?id=780
http://fiji.sc/bugzilla/show_bug.cgi?id=781

This is more consistent with the legacy IJ1 experience. It will also
respect the value of the "Use JFileChooser to open/save" setting,
whereas the previous code always used JFileChooser which is
nigh-unusable on OS X.

See also:
http://fiji.sc/bugzilla/show_bug.cgi?id=780
http://fiji.sc/bugzilla/show_bug.cgi?id=781
@ctrueden
Copy link
Member Author

I'd appreciate a code review before merging this. In particular:

  • What should the title for the OpenDialog and SaveDialog be? I don't want to just use "Open" and "Save" without first checking what ImageJ1 does normally—I think we should match that.
  • In my quick testing, I'm concerned that either A) this change somehow breaks the legacy layer; or B) there was already something wrong with the legacy layer. Specifically: File > Open does not seem to use SCIFIO anymore, but rather falls back to Bio-Formats (!) for .fake files, which suggests that vanilla ImageJ1 is being used. No time to debug tonight, unfortunately.

@dscho
Copy link
Contributor

dscho commented Jun 13, 2014

A quick git grep 'new OpenDialog' suggests that Open (and likewise Save) are reasonable choices!

dscho added a commit that referenced this pull request Jun 13, 2014
LegacyUI: use IJ1's dialogs for opening and saving
@dscho dscho merged commit fe0fc32 into master Jun 13, 2014
@dscho dscho deleted the file-chooser-woes branch June 13, 2014 00:22
@ctrueden
Copy link
Member Author

Regarding the second bullet point, turns out I was an idiot and just had SCIFIO disabled in my testing. whew!

@dscho
Copy link
Contributor

dscho commented Jun 13, 2014

@ctrueden Heh. It's all too easy to get confused, what with the flurry of bug fixes we're performing these days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants