Converters #47
Closed
Converters #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can introduce this command later!
* Introducing Scale Pixels
Conflicts: src/main/java/net/imagej/ops/normalize/NormalizeImgRT.java src/main/java/net/imagej/ops/scalepixel/ScalePixelsIterableRT.java
* Remove RealType restriction on generics
We need to be more specific about what we want to create. the assumption that the OpService actually can figure out what to create given the input parameters may not always hold.
this implementation is easier to understand and even more flexible
|
@hinerm's work on the convert-numbers branch (see also #54) may impact this work. From our planning doc: "Could also have SJC converters that convert whole images, as well as single element type objects." |
|
@dietzc Unless you want feedback sooner, I will wait on this one till the January hackathon. |
|
@ctrueden thats completely fine. I want to go over this stuff anyway as soon as the automatic "op-converters" are available (hackathon?!). |
|
needs more polishing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NEEDED
@dscho I tried to implement Normalizers and Converters in a clean way, especially such that we can optimize each and every op. Can you please review, comment, etc on the design. I'm aware of the fact that the commit messages aren't perfect, but I really wanted to see progress while I'm here and we really have to discuss design issues. (I will clean up the history later of course :-))
You can start reviewing the design by following the examples provided in the ConvertIterableTest I guess.
Anyway: We also need to figure out a way to auto-generated e.g. fast variants of GenericScaleIterableRT (ArrayImg/PlanarImg etc, for all the type combinations). We will see this pattern occur more frequently: Given one or two ArrayImgs of same or different type apply a pixel-wise function on them. Maybe we can have a more generic way for creating such classes? any idea?
to make this clear: this is not intended to be merged. I will redo the commit history after we agreed if the design is OK. I'm really nitpicking on the design here because I have no idea if this is good or not. Please simply start from the provided test-case and have a look.