-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on AppVeyor #5
Comments
First I introduced AppVeyor to imagemin-jpeg-recompress. https://github.com/imagemin/imagemin-jpeg-recompress#imagemin-jpeg-recompress-- |
We should switch that Travis badge to be flat so they look nicer together. |
Yup |
According to the discussion imagemin/meta#5
shields have a badge for Appveyor too. |
I'd rather use original AppVeyor badge. |
True. |
@shinnn, can we remove AppVeyor from the repos? It's slow, mostly fails and doesn't show any good output. We can use it on the main imagemin repo (and maybe the plugins) when/if we can use a newer npm version. |
We can fix a lot more error on Windows with more cross-platform code, like this commit. I still want to continue testing on AppVeyor. However, as you know, it's very hard to rebuild binaries on AppVeyor. They fails without any outputs and we can't find the causes. |
I'm fine with us continuing using AppVeyor as long as I don't have to care about it. |
I don't care if it fails and shows good error output. But currently it just shows that it failed but not why. AppVeyor is so bad imo. The commit you're referring to is a conscious decision by me (to use |
I agree with you that we shouldn't write stupid workarounds. OK, now I'd like to propose:
What do you think? |
Yes, it's top pri for |
@shinnn, yup, sounds good to me. Build scripts won't work on Windows 90% of the time anyway. @sindresorhus, I could write a fast temporary patch that implements it if you want to. |
http://www.appveyor.com/
We should check if imagemin and its plugins work well on Windows, like Grunt projects.
The text was updated successfully, but these errors were encountered: