core: Fixed Truelight LUT reading bug #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Truelights 3D LUTs are now read with proper scaling. Previously, Truelight LUTs appeared too dim by a factor of roughly lut3dsize/(lut3dsize+1). (~6% for a 16x16x16) - Truelight LUTs that only specify the 1D or 3D component are now supported. - Truelight LUT reading now properly ignores data past the '# end' tag. - Known Issue: 1D shaper luts (InputLUT) using integer encodings (vs float) are not supported. This will be added once suitable examples can be found. (Suitable for 0.8 / 1.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be added once suitable examples can be found.
(Suitable for 0.8 / 1.0)