HighlightCode#highlight makes too many assumptions

[citizen428]

In line 14 of plugins/pygments_code.rb:

str = pygments(str, lang).match(/<pre>(.+)<\/pre>/m)[1].to_s.gsub(/ *$/, '')

I've seen this fail both with a NoMethodError for match on nil (when the pygments method returns nil although it shouldn't) as well as with a NoMethodError for [] on nil when the match fails.

True, all of this was triggered by not using raw and endraw appropriately, but still I feel that the above code is unsatisfying and could handle the situation better. Throwing exceptions and leaving the user with no clue as to what happened is rather unacceptable IMHO...

I do have workaround code that at least renders an empty highlighting box into the page so the build doesn't fail and I know which snippet caused the problem, but I won't attach it here for now because (a) it's hacky and (b) I don't think it's really the best way to handle this.

I volunteer to implement a solution though once we have agreed here how and if this should be addressed.