Fix case-sensitive categories will override each other.

[hSATAC]

Let's say I have 2 categories Git and git.

For category links, they were generated by category.to_url so they will link to the same url categories/git

But in plugins/category_generator.rb, they were treated like different categories, so one of them will be overridden by the other. I think we should treat these as the same category. After all, they're generated to the same folder, and linked to the same url.

[parkr]

Looks like old, non-downcase categories will be saved in the new Hash. Is that intended?

[hSATAC]

Which lines are you referring to?

Basically this changes did two things:

1. downcase the categories and loop them into write_category_index
2. Method swizzling site_payload, downcase and merge categories and their posts for CategoryIndex#render

[tamouse]

This seems rather verbose.

[hSATAC]

Are you suggesting removing the comment?

[tamouse]

No, I was refering to the code below, sorry -- It just seems like a lot of intermediate assignments. The comment above is actually great as it gives the reason for this being there.

[parkr]

I've had people complain to me about downcasing of categories. For example, I really want the category Cornell to have that capital C, but maybe for git I don't care about case. To me, the user should be managing categories and we shouldn't necessarily be saying, "look, I don't care about the case in your categories, it's all the same to me".

[hSATAC]

@parkr I agree with your point of view, but the problem here is that, there are 2 parts of this thing: links and folders. This plugin downcase links but not the folders. What I am trying to do here is make this consistent - either downcase all of them or just leave them alone.

[parkr]

@hSATAC That makes sense. Won't it break links on current sites?

[hSATAC]

AFAIK it won't.

The links was generate by category.to_url, which I did not change. And all the strings after to_url will be downcased Git => git, git => git. This is exactly what this PR is for.

see:
https://github.com/hSATAC/octopress/blob/07e160580de7cba65ac494169dc5cd6c8ebb3fbb/plugins/category_generator.rb#L195