-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow version 2.0 (master) to use linenos, start and mark in code block #1485
base: master
Are you sure you want to change the base?
Conversation
This is actually a hack getting from version 2.5's plugins I just make the related plugins to get work in 2.1, then apply the default themes in 2.5 in this 2.1 branch
👍 |
Any updates on this? Can this be merged now? |
+1 Looking for this functionality as well. |
This LGTM. Might be nice to have as work on 3.0 is continued. What say you, @imathis? |
Yes please! I tried installing octopress 3.0 but am facing a roadblock due to some compilation errors which I can't figure out how to solve. It would be great to have codefence like features in 2.0 too. |
3.0 hasn't been publicly released yet, so there are still some problems with it. |
I was also confused by the lack of support for these features in master, since the documentation on the website (dated 2011) describes these features. +1 for getting it merged |
Thanks for the PR, but this seems to include some changes which are unrelated to adding these features. I've separated out the code highlighting core to octopress/code-highlighter and right now I'm working on reintegrating that into the 2.0 release. If all goes well I'll have this fixed in the next day or two. |
Hey @imathis any updates? |
👍 |
This is only for people who wants "start, mark" in the code block in 2.0 (master).
As I can't run branch 2.5 on my Windows machine.
As it looks like most of the development effort are now in 3.0, therefore I decided to merge only the corresponding plugins from 2.5 to
master
, I also updated the default theme asmaster
doesn't support for line number.Reference I used include Ricardos code:
https://groups.google.com/d/msg/octopress/y1IlHmFYydQ/MCSBrDrL1XIJ