Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes analytics a little more generic #177

Closed
wants to merge 1 commit into from
Closed

Makes analytics a little more generic #177

wants to merge 1 commit into from

Conversation

joeybeninghove
Copy link

Created a generic analytics.html include which includes the google_analytics.html by default and also the custom/analytics.html include which can contain custom analytics code such as for getclicky.com and others. Updated the default layout to include the generic analytics.html include instead of directly including the google_analytics.html one only.

If this isn't something you think is necessary in the Octopress core, I understand. But let me know what you think.

Thanks!
Joey

…alytics.html by default and also the custom/analytics.html include which can contain custom analytics code such as for getclicky.com and others. Updated the default layout to include the generic analytics.html include instead of directly including the google_analytics.html one only
@imathis
Copy link
Owner

imathis commented Sep 28, 2011

As I look at this, I'm thinking it might be better to create a more generic custom partial. Analytics is only one possible usage and the real point of this is to be able to add your own scripts after the page loads. What do you think? Got an idea for what it should be called?

@imathis imathis closed this Sep 28, 2011
@joeybeninghove
Copy link
Author

Ah, yes. I can see how that could be useful too. I guess I was thinking that keeping with the theme of "guiding" hackers down the path of publishing a blog, making an explicit analytics plugin would encourage their use, which I personally think is important. But of course I guess not everyone shares that view.

A custom partial for including scripts after page load would be useful as a generic plugin as well. I'd be fine with whatever you suggest on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants