changing two system() calls to use corresponding FileUtils methods #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs on Windows 7and duplicated a call just a few lines earlier
…try; this was to fix a deployment issue to GitHub Pages on Windows 7
|
I just tested 82942bd on OSX 10.6 with ruby 1.9.2 and it fails with cp -r public/* _deploy rake aborted! No such file or directory - public/* /Users/jtang/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/fileutils.rb:1423:in `stat' /Users/jtang/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/fileutils.rb:1423:in `block in fu_each_src_dest' /Users/jtang/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/fileutils.rb:1437:in `fu_each_src_dest0' /Users/jtang/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/fileutils.rb:1421:in `fu_each_src_dest' /Users/jtang/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/fileutils.rb:432:in `cp_r' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/file_utils_ext.rb:36:in `cp_r' /Users/jtang/develop/jcftang.github.com/Rakefile:233:in `block in ' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:205:in `call' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:205:in `block in execute' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:200:in `each' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:200:in `execute' /Users/jtang/develop/jcftang.github.com/Rakefile:204:in `block in ' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:205:in `call' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:205:in `block in execute' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:200:in `each' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:200:in `execute' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:158:in `block in invoke_with_call_chain' /Users/jtang/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/monitor.rb:201:in `mon_synchronize' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:151:in `invoke_with_call_chain' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/task.rb:144:in `invoke' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:112:in `invoke_task' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:90:in `block (2 levels) in top_level' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:90:in `each' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:90:in `block in top_level' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:129:in `standard_exception_handling' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:84:in `top_level' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:62:in `block in run' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:129:in `standard_exception_handling' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/lib/rake/application.rb:59:in `run' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/gems/rake-0.9.2/bin/rake:32:in `' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/bin/rake:19:in `load' /Users/jtang/.rvm/gems/ruby-1.9.2-p290/bin/rake:19:in `' Tasks: TOP => deploy reverting the commit lets me deploy on OSX, i am running pretty much all the latest gems for this. |
|
@jcftang Woops, sorry. It should work now. Can you please retest? |
|
it's working again now, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eed92b6 is related to issue #190
bc14e14 simply removed a system() call that seemed to duplicate a FileUtils call just a few lines above it.
I'm not able to test these on OSX.