[DEV] Move rakefile configs #222

Closed
wants to merge 24 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

fhemberger commented Oct 16, 2011

I've setup this pull request for discussion and cherry-picking about code restructuring and to provide ideas for deployment.

and others added some commits Aug 25, 2011

Contributor

fhemberger commented on 7fadb6b Sep 24, 2011

Should have been "Adds method_missing for better error handling".

Sorry to cause more work with this one, just looked over it and noticed that I think it should read

{self.config['ssh_port']}

in this line, rather than just

{ssh_port}

when compared to the other settings.As I edited the Rakefile directly, I didn't realize this - I might be wrong, I'm neither too familiar with Ruby nor with this specific file, it just seems irregular.

Contributor

fhemberger replied Sep 27, 2011

Thanks, fixed.

Contributor

fhemberger commented Oct 17, 2011

See also #175 for deployment to Amazon.

Contributor

simensen commented Nov 14, 2011

I see a lot of work being done on configuration stuff in here. The changes look really good! Excited to see this stuff put into master. :)

Contributor

simensen commented Nov 16, 2011

I have been submitting pull requests (#283 and #278) to the move_rakefile_configs branch. Is that appropriate? I ask because I just realized that this PR is for merging move_rakefile_configs into master but it is not including any of my pull requests. I am hoping they don't get lost in the dust when/if this PR is merged.

@imathis Merge pull request #283 from simensen/move_rakefile_configs_server_po…
…rt_fix

Move rakefile configs server port fix
6f90bc3

imathis closed this May 22, 2012

@jonathannelson jonathannelson pushed a commit to jonathannelson/octopress that referenced this pull request Feb 14, 2013

Jonathan Nelson sidebar to #222 for h4 3b33e1a

@jonathannelson jonathannelson pushed a commit to jonathannelson/octopress that referenced this pull request Feb 14, 2013

Jonathan Nelson footer h4 color to #222 9e0f7bb

@jonathannelson jonathannelson pushed a commit to jonathannelson/octopress that referenced this pull request Feb 14, 2013

Jonathan Nelson footer h4 color to #222 87c8aaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment