Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteReader Exception thrown for browser-supported URLs that are non-spec #220

Closed
edmacdonald opened this issue Jun 27, 2017 · 1 comment
Closed

RemoteReader Exception thrown for browser-supported URLs that are non-spec #220

edmacdonald opened this issue Jun 27, 2017 · 1 comment

Comments

@edmacdonald
Copy link
Contributor

edmacdonald commented Jun 27, 2017 •
edited

The use of Uri.IsWellFormedUriString is causing an exception for Urls that may technically be invalid based on the RFC but are in use and supported by most, if not all, browsers. Here is an example from Volvo's site:

https://www.volvopartshop.com/ekmps/shops/tmsvolvo/images/v50-roof-rail-end-caps-black--front-or-rear-front-side-right-hand-18052-p[ekm]299x224[ekm].jpg

We are using ImageResizer in an environment where we don't have control over source image URLs.

I submitted a PR for a configuration option to skip this check, but for some reason (not code related) the build is failing.

-Ed
@lilith
Copy link
Member

lilith commented Nov 28, 2017

Fixed with #221

@lilith lilith closed this as completed Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lilith @edmacdonald