Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteReaderPlugin configuration option to skip Uri validation #221

Merged
merged 5 commits into from
Jun 28, 2017
Merged

RemoteReaderPlugin configuration option to skip Uri validation #221

merged 5 commits into from
Jun 28, 2017

Conversation

edmacdonald
Copy link
Contributor

The use of Uri.IsWellFormedUriString is causing an exception for Urls that may technically be invalid but are in use and supported by most, if not all, browsers. Here is an example from Volvo's site:

https://www.volvopartshop.com/ekmps/shops/tmsvolvo/images/v50-roof-rail-end-caps-black--front-or-rear-front-side-right-hand-18052-p[ekm]299x224[ekm].jpg

This option is necessary when using ImageResizer in an environment where one doesn't have control over source image URLs.

@lilith lilith merged commit 3200cb7 into imazen:develop Jun 28, 2017
@lilith
Copy link
Member

lilith commented Jun 28, 2017

LGTM. Travis is for deploy-related stuff; we can ignore it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants