fix slots error with web components #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with shoelace button and swiper. Works like a charm |
familyfriendlymikey
pushed a commit
that referenced
this pull request
Mar 6, 2023
haikyuu
added a commit
that referenced
this pull request
Mar 31, 2023
* support iife loader suffix * Add vite middleware e2e test * Add vite middleware e2e test * fix svg plugin + add support for worker + web + SSR styles to remove the flash of unstyled content in dev * add typescript paths plugin +client default config * add esm build of program.imba + externalize pkgs * alter compilation of <script src="x"> for vite * add setupVite that operates in a basic linked mode For now, it is used to skip server live reloading if client side reloading kicked in * remove vite-plugin dir * move vite plugin to imba package * update e2e projects * update workflow for vite e2e tests * update ignored files * update e2e tests * finally ... * auto inject fouc styles in dev mode + remove them * add type declaration for imba.setupVite * fix e2e tests in CI * comment server options * fix test * cleanup and fix windows * create dev ssr styles for each entry in dev * try to fix e2e tests * wip * skip building imba again + increase timeout * use outdir option + put built client in /public * refactor to improve prod performance * use sheets injection for vite * remove outdir option and fix windows build * use normalize path 4 windows -_- * Add silent to tsconfig paths + install as dev dep * move setupVite utility to imba/plugin * support importing dependencies inside iife imports * fix issue with ejecting in non esm projects * simplify config file retreival logic * use vite config paths fork * fix windows path resolving * use path to file url for windows * use one config file imba.config.x * add defineConfig to imba typings * use mjs in test setup, deps prompt, optional deps * wip (stash) * add test setup * ignore external suffix in tests * dedupe imba (avoid multiple versions weird errors) * wip undo to see * merge user vite config with default imba config * use imba config from imba.config.js file in vite * cleanup + fail gracefully when no imba config * remove duplicate declaration * change vite version to fix CI * change npm i to npm ci * use node 18 instead of 16 * update lockfile for e2e folder * wip * new package-lock file * wip force * wip * add link script * fix version * add info and clean scripts * npm i * clean -> synctest * update deps in e2e tests * fix tests by pinning puppeteer * rename inspector to html * add bundler option in config file * imba serve without entry / entry = index.html * imba build with no entry / entry = index.html * add port to imba serve + relax deps * Add imba preview command * Add support for imba serve using vite * fix slots error with web components (#825) * fix tests (externalize colors) * add host option to serve command * fix merging config + update vite-node ++ * fix e2e tests and bug with define * remove magic string dependency * clean up --------- Co-authored-by: familyfriendlymikey <ozmichaelt@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #680