Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An invalid transformation parameter can generates a PHP Warning #237

Merged
merged 2 commits into from
Dec 26, 2013
Merged

An invalid transformation parameter can generates a PHP Warning #237

merged 2 commits into from
Dec 26, 2013

Conversation

christeredvartsen
Copy link
Member

When the t query parameter is not used as an array, or if any of its elements are not strings, Imbo generates PHP Warnings. Imbo should instead respond with HTTP 400.

Both these examples will generate errors:

t[][]=desaturate
t=desaturate

christeredvartsen added a commit that referenced this pull request Dec 26, 2013
An invalid transformation parameter can generates a PHP Warning
@christeredvartsen christeredvartsen merged commit fa99236 into imbo:develop Dec 26, 2013
@christeredvartsen christeredvartsen deleted the validate-transformations branch December 26, 2013 10:06
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f8a05ce on christeredvartsen:validate-transformations into * on imbo:develop*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

2 participants