fix: deprecate domain sharding #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayeb
approved these changes
Apr 26, 2019
sherwinski
force-pushed
the
deprecate-domain-sharding
branch
3 times, most recently
from
1d1186c
to
9a86fd3
Compare
sherwinski
force-pushed
the
deprecate-domain-sharding
branch
from
9a86fd3
to
507ab19
Compare
|
To avoid potentially polluting our users' error logs, we will suppress the deprecation warning by using |
jayeb
approved these changes
May 1, 2019
sherwinski
force-pushed
the
deprecate-domain-sharding
branch
from
507ab19
to
9d20418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the process of deprecating, and eventually removing, domain sharding from the imgix-php library.
The
UrlBuilderobject will now generate a warning when users attempt to initialize it by passing in multiple domains in the form of an array.