fix: remove deprecated domain sharding functionality #45
Conversation
src/Imgix/UrlBuilder.php
Outdated
| @trigger_error($warning_message, E_USER_DEPRECATED); | ||
| $this->domains = $domains; | ||
| if (!is_string($domain)) { | ||
| throw new \InvalidArgumentException("UrlBuilder must be passed a valid string domain"); |
There was a problem hiding this comment.
pushes up glasses
Can we change this message to "UrlBuilder must be passed a string domain"? The validity of the string isn't technically relevant here, since validity isn't checked until L19.
There was a problem hiding this comment.
I did that to be consistent with imgix-core-js but I see your point. If we change it here, should we carry it over everyone else that applies?
There was a problem hiding this comment.
Ah dinger, shoulda caught it there. I'd say change it here and make a note somewhere to roll that in the next time we change something in imgix-core-js. I don't think it's worth downshifting just to go back and change that, I'd rather you keep forging ahead.
|
Oh, and obviously these broken tests are a problem. |
|
Sigh yea, I'm combing through phpunit's github & travis documentation to see if there's a quick fix to this. I'm not sure how travis determines what version of phpunit should be used per job, but I don't think it should be defaulting to the version that isn't supported on a particular version of PHP. Ideally I'd like to avoid just having to remove those versions altogether. |
Introduced in #45, this pre-flight script ensured a compatible version of phpunit was installed for php versions ≥ 7.0
Introduced in #45, this pre-flight script ensured a compatible version of phpunit was installed for php versions ≥ 7.0
Introduced in #45, this pre-flight script ensured a compatible version of phpunit was installed for php versions ≥ 7.0
Introduced in #45, this pre-flight script ensured a compatible version of phpunit was installed for php versions ≥ 7.0
This PR removes all domain sharding functionality from imgix-php, following its deprecation in #42