Skip to content
This repository has been archived by the owner on Aug 14, 2023. It is now read-only.

Need more Pass-through Attributes #8

Closed
chris-79 opened this issue Sep 22, 2016 · 4 comments
Closed

Need more Pass-through Attributes #8

chris-79 opened this issue Sep 22, 2016 · 4 comments

Comments

@chris-79
Copy link

Looks like these aren't being passed-through:

id, class, and rel

Might be more standard-ish ones, but I just came across these.

– Chris :)
@paulstraw
Copy link
Contributor

paulstraw commented Oct 4, 2016 •
edited
Loading

Hey @chris-79, I'm adding all <img> and "Global attribute" values from the MDN reference to the attribute whitelist. That will include id and class, but rel in particular is supposed to be used only with <a>, <area>, and <link>.

@chris-79
Copy link
Author

chris-79 commented Oct 4, 2016

Sweet! 😄

paulstraw added a commit that referenced this issue Oct 4, 2016
@paulstraw
Statamic 1.x implementation of pass-attrs for #8
2cef49c
paulstraw added a commit that referenced this issue Oct 4, 2016
@paulstraw
Merge pull request #9 from imgix/8-v1-pass-through-attriubutes
3188db6 
Statamic 1.x implementation of pass-attrs for #8
paulstraw added a commit that referenced this issue Oct 4, 2016
@paulstraw
Statamic 2.x implementation of pass-attrs.
9b0867a 
Closes #8
@paulstraw paulstraw mentioned this issue Oct 4, 2016
Merged
@paulstraw
Copy link
Contributor

Alright @chris-79, this has been updated + released in 1.1.1 and 2.2.1, for Statamic 1.x and 2.x, respectively.

@chris-79
Copy link
Author

chris-79 commented Oct 5, 2016

You rock, man! 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulstraw @chris-79