-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PE-4862] Updates background component to merge props #932
Conversation
tests are failing due to config file issues, trying to resolve with the following suggestions from, but no success yet: Edit: this is a browser-tool orb issue that cannot be solved currently. CircleCI-Public/browser-tools-orb#98 (comment), so we'll ignore tests for now (locally they all pass) UPDATE: This has been resolved by updating the node version in the config file |
0d5eaa3
to
048b4fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: great work on this! Nearly there.
comment: left one blocking question. Once that's answered/addressed we should be ready to merge.
90ad813
to
e587057
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Left one non-blocking suggestion.
e587057
to
06a3430
Compare
🎉 This PR is included in version 9.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR address issue: Background component doesn't utilize ImgixProvider's domain parameter
mergeComponentPropsHOF
andprocessPropsHOF
now wrapwithContentRect("bounds")(BackgroundImpl)
BEFORE:
Imgix domain prop was not being passed to Background component from ImgixProvider
AFTER:
Imgix domain prop can be access by Background component from ImgixProvider
How to test:
It takes a little set up to test, you'll need to add
react-imgix
to a repo and link to the working branch:yarn create vite my-react-app --template react
react-imgix
and pull this branch, runnpm run build
my-react-app
:yarn link react-imgix
my-react-app
run:yarn dev
App.jsx
with this code snippet:sdk.mp4